Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template] Dark mode #348

Open
xfq opened this issue Feb 24, 2021 · 3 comments
Open

[template] Dark mode #348

xfq opened this issue Feb 24, 2021 · 3 comments
Assignees
@xfq
Labels
template

Comments

@xfq
Copy link
Member

xfq commented Feb 24, 2021

Is there an interest in implementing dark mode for the charter template?
@xfq xfq added the template label Feb 24, 2021
@xfq
Copy link
Member Author

xfq commented Feb 24, 2021

I have a semi-finished example here for your reference: https://xfq.github.io/testing/dap-charter-dark-mode/DASCharter-2020.html

@svgeesus
Copy link
Contributor

svgeesus commented May 3, 2021

The preview looks okay and I think this is a nice thing to do. @xfq what items remain to be finished?

@xfq
Copy link
Member Author

xfq commented May 7, 2021

The preview looks okay and I think this is a nice thing to do. @xfq what items remain to be finished?

Two things that I currently think of:

  • The W3C logo is too bright. We should consider replacing it with white text on a blue background.
  • The contrast of the Timeline table and the testing policy (in § 3 Success Criteria) is too low and needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xfq xfq

Labels
template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svgeesus @xfq