-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[selectors] :user-error or :user-invalid? #1329
Comments
They were definitely meant to refer to the same thing, but it seems that choosing the right name for it was problematic from the very beginning (https://lists.w3.org/Archives/Public/www-style/2012Aug/0749.html). IIRC, at some point there was another discussion about renaming it, but I can't find the link. Maybe the current state of the section is the result of the attempt of such renaming that wasn't finished? But I found a similar question in the www-style maillist: https://lists.w3.org/Archives/Public/www-style/2016Jun/0166.html. |
They were meant to be different per the discussion in https://lists.w3.org/Archives/Public/www-style/2012Aug/0749.html However that was five years ago, and since, I don't think the concept of :user-error has made any progress (no implementations AFAIK), whereas :user-invalid has been long prototyped (and used) in Firefox as :-moz-ui-invalid for many years https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-ui-invalid Thus at this point, we should wrap-up selectors-4 with :user-invalid, and remove / postpone any separate :user-error for a future draft. |
@tantek, the discussion you link to is about a distinction between (Fwiw, the reason Tab and I suggested |
Here's the link to the renaming discussion:
https://www.w3.org/mid/CADhPm3v+WfeGQfBwwx8QBuiOjn2k38V_DcKW17Cm81VgZb1nbQ@mail.gmail.com
|
Given the leeway in when this is allowed to match it's tricky to write tests for this. Are there any cases where everyone agrees that it should match, so that tests can be written for that at least? For example, typing at least one character and then moving the focus to another input element? Anyway, a test to check for being supported at all was simple, review appreciated: web-platform-tests/wpt#8899 Context: me looking at a normative spec change without tests every week this quarter. |
@foolip Yes, I think your example counts. :) It's a judgement call, but that doesn't mean we can't test it: we pick a reasonable interpretation, and if a UA fails because it disagrees with that reasoning it can argue for the test to be altered. Otherwise it needs to pass it. ;) As for the PR: parsing support tests are dangerous when there is no corresponding functional test. It encourages browsers to support parsing without supporting the function--it's been a problem in the past, and it seriously breaks CSS's forwards-compatible parsing invariants. |
Filed web-platform-tests/wpt#9346 for such a test. |
Selectors spec sometimes uses
:user-error
and sometimes:user-invalid
, presumably to refer to the same thing.This problem was noticed in #579, which was closed by mistake, so I'm posting this new issue so that it's not lost. Feel free to close this and reopen the old one.
The text was updated successfully, but these errors were encountered: