Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-fonts] font-size-adjust: percentage #5547

Closed
litherum opened this issue Sep 23, 2020 · 3 comments
Closed

[css-fonts] font-size-adjust: percentage #5547

litherum opened this issue Sep 23, 2020 · 3 comments
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. css-fonts-4 Current Work

Comments

@litherum
Copy link
Contributor

litherum commented Sep 23, 2020 •
edited
Loading

https://www.w3.org/TR/css-fonts-4/#font-size-adjust-prop

The value supplied to font-size-adjust represents the fraction of the font-size which the aspect value should fill. Presumably this should be a percentage instead of a raw number?

We probably can't remove the raw number, since it's shipping in Firefox, but we can at least make the grammar none | <number> | <percentage>.
@litherum
Copy link
Contributor Author

@jfkthame

@fantasai
Copy link
Collaborator

I'd rather not add percentage as a synonym of number. It doesn't get us anything new, and will block us if at some point we want something new mapped to percentages.

@fantasai fantasai added the css-fonts-4 Current Work label Sep 24, 2020
@fantasai fantasai changed the title font-size-adjust: percentage [css-fonts] font-size-adjust: percentage Sep 24, 2020
@litherum
Copy link
Contributor Author

Right, makes sense.

@fantasai fantasai added the Closed as Retracted When the person who raised the issue thinks that there's no issue after all. label Sep 27, 2020
@Crissov Crissov mentioned this issue Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed as Retracted When the person who raised the issue thinks that there's no issue after all. css-fonts-4 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fantasai @litherum