Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[motion-1] What is the expected serialization for <position> in circle and ellipse if the explicit center is not given? #514

Closed
BorisChiou opened this issue May 24, 2023 · 3 comments
Labels

Comments

@BorisChiou
Copy link

Per some comments from web-platform-tests/interop#340. It seems the serialization of <position> is a little bit unclear to me.

Per [css-shapes-1]

omitting components when possible without changing the meaning

And its example shows:

Omitting components means that some default values do not show up in the serialization. But since always uses the 2- or 4-value form, a default is not omitted.

So if we use circle(closest-side), what is the expected serialization? If we serialize it as circle(at 50% 50%), this seems incorrect to me because we do not use the standard default for motion path:

If circle() or ellipse() is used, and an explicit center position is not given, they default to using the offset starting position, rather than their standard default:

So I think we shouldn't serialize its default center position (for both specified value and computed value) because we don't use the standard default for circle and ellipse if the explicit center is not given. In other words, we should omit this component because it has special meaning.

cc @tabatkins @danielsakhapov

@BorisChiou
Copy link
Author

BorisChiou commented May 24, 2023

w3c/csswg-drafts#8695 is related to this.

@BorisChiou
Copy link
Author

I'd like to follow the proposal mentioned in w3c/csswg-drafts#8695 (comment):

Fix the examples and tests, and file implementation bugs, allowing at to be omitted, consistent with our general serialization principles.

@BorisChiou
Copy link
Author

BorisChiou commented May 25, 2023

I think w3c/csswg-drafts#8695 (comment) is the proposed solution for this spec issue. (And so let's make this duplicated by w3c/csswg-drafts#8695.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant