Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Provide IndirectContainer tests #208

Open
sspeiche opened this issue Oct 20, 2014 · 3 comments
Open

Provide IndirectContainer tests #208

sspeiche opened this issue Oct 20, 2014 · 3 comments

Comments

@sspeiche
Copy link
Contributor

There are 3, they are current marked not implemented.

Even though there are only 3 test cases now, I believe one of them would require a number of separate tests to satisfy the claim:
"5.5.1.1 Each LDP Indirect Container must also be a conforming LDP Direct Container as described in section 5.4 Direct, along with the following restrictions."
https://dvcs.w3.org/hg/ldpwg/raw-file/default/ldp.html#ldpic-are-ldpcs

It is not enough to mark the test IndirectContainerTest::testConformsIcLdpContainer() as converedByTests=DirectContainerTest.class as the Direct Container tests as-is should fail on Indirect Containers. Realistically, there should be tests the check for the right membership pattern like there is done in DC tests: some could be reused perhaps as-is (Prefer) but others may need to be parameterized to factor in ldp:insertedContentRelation or a utility function created that takes as a parameter the membership pattern to validate.

@sspeiche
Copy link
Contributor Author

It would be good if someone who has an IndirectContainer implementation to take on writing the tests for the WG test suite.

Any takers? @nandana @jamesrdf @azaroth42 @bblfish @MiguelAraCo

@MiguelAraCo
Copy link
Contributor

If you are okay with it, I can do it. This is my first time contributing to a project like this, so I'll be asking a lot of questions (bare with me please).
First of all, what's the procedure to contribute? Should I start working with the tests in a fork and just create pull requests for the new code?

@sspeiche
Copy link
Contributor Author

@MiguelAraCo usual git workflow: fork, commit and create pull request. Just make sure if you have multiple PRs you use separate branches on your fork. Let me know if more questions and thanks for the help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants