-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon purpose "any" is confusing #1094
Comments
Yeah, we should consider if it does affect the parsing algorithm. |
Marking as a potential bug also... need to investigate actual usage and impact of any change we make here. |
@diekus Can you grab the usage stats from our last crawl? I don't have access anymore. |
This came out of a discussion Marijn and I were having on here (very long thread). I don't think Marijn was asking to change the name (and I don't think we should). What we should do is clarify the wording of what it means. It wouldn't be a breaking change. I think there are two separate issues here which we should tease apart:
On the first: I thought it was pretty clear from the way we have been doing things, but surprised to learn how ambiguous it is in the text itself, so I think we should clear it up. There are two possible reads here:
This is complicated by the fact that a user agent can technically do whatever it wants with an icon, for example, put the icon inside a circle, apply shadows, etc. But there should be SHOULD NOT requirements around applying treatments to icons that are only tagged with
So there is actually a valid use for a On the second: I actually don't think it's that necessary for us to exactly specify what "most appropriate" means in terms of icon sizes. The user agent is presented with a bunch of icons of different sizes. It can be left as an implementation detail which to pick. (e.g. on some systems you might want to choose the one that's closest to the size you need but larger; on other systems you may be forced to pick exactly one icon to represent your app, so you pick the largest one and store it and the OS scales it; others may have a maximum icon size, so you have to pick the largest one smaller than that, etc.) We shouldn't be prescriptive about icon size selection. |
From discussions on other bugs and elsewhere I learned that the "any" purpose does not in fact mean that "The user agent is free to display the icon in any context.", but rather that the icon can be used in any context for which no other purpose has been defined (i.e. icons without explicit purpose "maskable" should not be masked).
While the ship has sailed as far as naming goes, I do think it would be good to be very explicit about this in the explanation of what the "any" purpose actually means and how purpose of an icon ties into icon selection logic.
If for example the "most appropriate" icon was actually defined in an algorithm (related discussion in #925 (comment)) that would probably have avoided confusion here, as such an algorithm would presumably have included the purpose of icons, but if the spec doesn't want to define that, at least some non-normative text would be good I think.
The text was updated successfully, but these errors were encountered: