Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Picture-in-Picture steps should queue a task #225

Open
chrisn opened this issue May 2, 2024 · 0 comments · May be fixed by #233
Open

Disable Picture-in-Picture steps should queue a task #225

chrisn opened this issue May 2, 2024 · 0 comments · May be fixed by #233

Comments

@chrisn
Copy link
Member

chrisn commented May 2, 2024

Raised by @marcoscaceres in #224, about the Disable Picture-in-Picture steps:

This should queue a task or something... promises can't be rejected synchronously here.

Consider, what should happen here:

const video = document.querySelector("video");
await video.requestPictureInPicture();
video.setAttribute("disablePictureInPicture", "");
video.removeAttribute("disablePictureInPicture");

That should probably have no effect. The task at the turn of the event loop should check if the attribute is still present and reject the promise(s) at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant