Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's standardize window.orientation... #249

Open
2 tasks
marcoscaceres opened this issue Apr 13, 2023 · 2 comments
Open
2 tasks

Let's standardize window.orientation... #249

marcoscaceres opened this issue Apr 13, 2023 · 2 comments

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented Apr 13, 2023 •
edited
Loading

The WHATWG compat spec currently specifies window.orientation, but it could just be moved here. It's interoperable and I don't imagine it is going anywhere.

  • move spec and update it
  • add WPTs to check the orientation
@marcoscaceres marcoscaceres mentioned this issue Apr 13, 2023
Closed
1 task
@karlcow karlcow mentioned this issue Apr 14, 2023
Open
@annevk
Copy link
Member

annevk commented Apr 26, 2023

That makes sense to me. It's always better to define features (even if they're bad) closer to the source.

@marcoscaceres
Copy link
Member Author

ok, cool. I'll send a PR and coordinate with @miketaylr for the WHATWG compat side whatwg/compat#239

@marcoscaceres marcoscaceres changed the title Should we standardize window.orientation? Let's standardize window.orientation... May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoscaceres @annevk