Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mode" of a shadow root which <use> element uses is unclear #396

Closed
hayatoito opened this issue Mar 28, 2018 · 2 comments
Closed

"mode" of a shadow root which <use> element uses is unclear #396

hayatoito opened this issue Mar 28, 2018 · 2 comments

Comments

@hayatoito
Copy link
Member

The spec says <use> element uses a shadow root.
https://svgwg.org/svg2-draft/struct.html#UseShadowTree

However, I guess, this part was written at the era of Shadow DOM v0, which is now dead.
Shadow Root in Shadow DOM v1 has mode, which changes the behavior of a shadow root.

It would be better to clarify which shadow root, open or closed, <use> elements use. That is observable.

The relevant discussion in chromium is
https://chromium-review.googlesource.com/c/chromium/src/+/981817

@hayatoito
Copy link
Member Author

It looks the space says:

The shadow tree is open (inspectable by script), but read-only. Any attempt to directly modify the elements, attributes, and other nodes in the shadow tree must throw a NoModificationAllowedError.

That sounds closed mode to me. I think we can remove this paragraph if the spec can use Shadow DOM v1's terminology.

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Apr 2, 2018

Closing as a duplicate of #363. I think the discussion there is definitely in favor of making the shadow tree closed, but if you have any other suggestions on cleaning up the interfaces to be more consistent with the rest of Shadow DOM, we'd appreciate your input, @hayatoito!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants