Skip to content

Commit 9a4d801

Browse files
committed
Corrections in the spec language.
1 parent 69cd298 commit 9a4d801

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

dist/spec/index.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1677,8 +1677,8 @@ <h3 class="heading settled" data-level="1.3" id="use-cases"><span class="secno">
16771677
<li data-md>
16781678
<p>An existing web application interacts with the DOM mostly using XSS-safe
16791679
patterns (i.e. withour using <a data-link-type="dfn" href="#injection-sink" id="ref-for-injection-sink">injection sinks</a>). In a few places, however,
1680-
it resorts to using risky patterns like calling into <code>innerHTML</code>, <code>eval</code>, or
1681-
creating <code>javascript:</code> URIs.</p>
1680+
it resorts to using risky patterns like loading additional script using
1681+
JSONP, calling into <code>innerHTML</code> or <code>eval</code>.</p>
16821682
<p>Review finds that those places do not cause XSS (e.g. because
16831683
user-controlled data is not part of the input to those sinks), but it’s
16841684
hard to migrate the application off using these patterns.</p>
@@ -1709,19 +1709,19 @@ <h3 class="heading settled" data-level="2.1" id="injection-sinks"><span class="s
17091709
<p>Examples of injection sinks include:</p>
17101710
<ul>
17111711
<li data-md>
1712-
<p>Functions that parse &amp; insert HTML strings into the document like <a href="https://www.w3.org/TR/DOM-Parsing/#widl-Element-innerHTML">Element.innerHTML</a> setter</p>
1712+
<p>Functions that parse &amp; insert HTML strings into the document like <a href="https://www.w3.org/TR/DOM-Parsing/#widl-Element-innerHTML">Element.innerHTML</a> setter,</p>
17131713
<li data-md>
17141714
<p>Setters for <code class="idl"><a data-link-type="idl" href="https://dom.spec.whatwg.org/#element" id="ref-for-element">Element</a></code> attributes that accept a URL of the code to load
1715-
like <code class="idl"><a class="idl-code" data-link-type="attribute" href="#dom-htmlscriptelement-src" id="ref-for-dom-htmlscriptelement-src">HTMLScriptElement.src</a></code></p>
1715+
like <code class="idl"><a class="idl-code" data-link-type="attribute" href="#dom-htmlscriptelement-src" id="ref-for-dom-htmlscriptelement-src">HTMLScriptElement.src</a></code>,</p>
17161716
<li data-md>
1717-
<p>Setters for <code class="idl"><a data-link-type="idl" href="https://dom.spec.whatwg.org/#element" id="ref-for-element①">Element</a></code> attributes that accept a code to execute like <code class="idl"><a class="idl-code" data-link-type="attribute" href="#dom-htmlscriptelement-text" id="ref-for-dom-htmlscriptelement-text">HTMLScriptElement.text</a></code></p>
1717+
<p>Setters for <code class="idl"><a data-link-type="idl" href="https://dom.spec.whatwg.org/#element" id="ref-for-element①">Element</a></code> attributes that accept a code to execute like <code class="idl"><a class="idl-code" data-link-type="attribute" href="#dom-htmlscriptelement-text" id="ref-for-dom-htmlscriptelement-text">HTMLScriptElement.text</a></code>,</p>
17181718
<li data-md>
1719-
<p>Functions that execute code directly like <code>eval</code>.</p>
1720-
<li data-md>
1721-
<p>Functions that accept URLs with <code>javascript:</code> scheme</p>
1719+
<p>Functions that execute code directly like <code>eval</code>,</p>
17221720
<li data-md>
17231721
<p>Functions that create a new same-origin <code class="idl"><a data-link-type="idl" href="https://dom.spec.whatwg.org/#document" id="ref-for-document">Document</a></code> with caller-controlled
1724-
markup like <code class="idl"><a data-link-type="idl" href="#dom-domparser-parsefromstring" id="ref-for-dom-domparser-parsefromstring">parseFromString()</a></code>.</p>
1722+
markup like <code class="idl"><a data-link-type="idl" href="#dom-domparser-parsefromstring" id="ref-for-dom-domparser-parsefromstring">parseFromString()</a></code>,</p>
1723+
<li data-md>
1724+
<p>Navigation to 'javascript:' URLs.</p>
17251725
</ul>
17261726
<p>An application is vulnerable to DOM XSS if it permits a flow of data from an
17271727
attacker-controlled source and permits that data to reach an injection sink

spec/index.bs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ which are substantially easier to safeguard, monitor and review.
111111

112112
* An existing web application interacts with the DOM mostly using XSS-safe
113113
patterns (i.e. withour using [=injection sinks=]). In a few places, however,
114-
it resorts to using risky patterns like calling into `innerHTML`, `eval`, or
115-
creating `javascript:` URIs.
114+
it resorts to using risky patterns like loading additional script using
115+
JSONP, calling into `innerHTML` or `eval`.
116116

117117
Review finds that those places do not cause XSS (e.g. because
118118
user-controlled data is not part of the input to those sinks), but it's
@@ -152,15 +152,15 @@ string value in a way that could result in XSS if that value is untrusted.
152152
Examples of injection sinks include:
153153

154154
* Functions that parse & insert HTML strings into the document like
155-
[[DOM-Parsing#widl-Element-innerHTML|Element.innerHTML]] setter
155+
[[DOM-Parsing#widl-Element-innerHTML|Element.innerHTML]] setter,
156156
* Setters for {{Element}} attributes that accept a URL of the code to load
157-
like {{HTMLScriptElement/src!!attribute|HTMLScriptElement.src}}
157+
like {{HTMLScriptElement/src!!attribute|HTMLScriptElement.src}},
158158
* Setters for {{Element}} attributes that accept a code to execute like
159-
{{HTMLScriptElement/text!!attribute|HTMLScriptElement.text}}
160-
* Functions that execute code directly like `eval`.
161-
* Functions that accept URLs with `javascript:` scheme
159+
{{HTMLScriptElement/text!!attribute|HTMLScriptElement.text}},
160+
* Functions that execute code directly like `eval`,
162161
* Functions that create a new same-origin {{Document}} with caller-controlled
163-
markup like {{DOMParser/parseFromString()}}.
162+
markup like {{DOMParser/parseFromString()}},
163+
* Navigation to 'javascript:' URLs.
164164

165165
An application is vulnerable to DOM XSS if it permits a flow of data from an
166166
attacker-controlled source and permits that data to reach an injection sink

0 commit comments

Comments
 (0)