-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definitions for w3id.org/security #15
Comments
@msporny note the use of documentLoader here https://github.com/w3c-ccg/lds-jws2020/blob/master/packages/json-web-signature-2020/src/__tests__/vc-js-tester.ts#L23 This is related to digitalbazaar/vc#80 When passing a custom document loader, I expect to be able to mutate I believe this is caused by: https://github.com/digitalbazaar/jsonld-signatures/blob/ee999c814fcbac15ea9ae86e56f9b127c544c970/lib/ProofSet.js#L74 |
I'd prefer to not see this kind of short circuiting of the documentLoader and instead, ship a default document loader, and make the library consumer intentionally choose to use it (make documentLoader a required argument, with no default). |
AFAIK, this has been addressed |
w3c-ccg/security-vocab#41
To be super clear... absence of vocabulary definitions in the default constants causes signature suite verification to fail without a custom context extension:
note the
type: '/JsonWebSignature2020',
!==JsonWebSignature2020
This can only be fixed by adding the context defintions to the document you are signing:
this causes
compactProof: false,
to be required.The text was updated successfully, but these errors were encountered: