Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant object properties in vsso-core #30

Open
jdacoello opened this issue Mar 19, 2022 · 1 comment
Open

Redundant object properties in vsso-core #30

jdacoello opened this issue Mar 19, 2022 · 1 comment

Comments

@jdacoello
Copy link

Current version of vsso-core has two object properties (hasStaticVehicleProperty, hasDynamicVehicleProperty) that should be merged into one (hasVehicleProperty).

The distinction between both is already handled by the class hierarchy as:

  • VehicleProperty
    • StaticVehicleProperty
    • DynamicVehicleProperty

Thus, having also two different properties is only giving space for potential mistakes when populating the graph in practice.
Even with just one property, one can easy retrieve with SPARQL the desired information:

What are all the static vehicle properties?

SELECT * WHERE { 
?vehicle vsso-core:hasVehicleProperty ?svp .
?svp a vsso-core:StaticVehicleProperty }

What are all the dynamic vehicle properties?

SELECT * WHERE { 
?vehicle vsso-core:hasVehicleProperty ?dvp .
?dvp a vsso-core:DynamicVehicleProperty }
@felix-loesch
Copy link

I agree. This can be simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants