Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in 'Read this page in' markup #697

Open
gosko opened this issue Dec 16, 2024 · 1 comment
Open

Typo in 'Read this page in' markup #697

gosko opened this issue Dec 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working website Issues related to the W3C website

Comments

@gosko
Copy link
Member

gosko commented Dec 16, 2024

The markup around 'Read this page in', for example on the Standards overview page has a typo:

<span><span lange="en">Read this page in:</span></span>

(lange instead of lang)

Also, is this span actually necessary? It's not present in the other translation files nearby, and I expect it's only needed when there is text written in a language other than the page's primary language. (but I'm just guessing)

Also I wonder if the other span is needed as well.

@gosko gosko added the website Issues related to the W3C website label Dec 16, 2024
@vivienlacourba vivienlacourba added the bug Something isn't working label Dec 17, 2024
@vivienlacourba
Copy link
Member

The markup around 'Read this page in', for example on the Standards overview page has a typo:

<span><span lange="en">Read this page in:</span></span>

(lange instead of lang)

Also, is this span actually necessary? It's not present in the other translation files nearby, and I expect it's only needed when there is text written in a language other than the page's primary language. (but I'm just guessing)

I agree with @gosko the <span lang="en"> does not seem necessary if it matches the current's page language.

Also I wonder if the other span is needed as well.

This <span> is present on https://design-system.w3.org/components/translations.html and indeed seem superfluous at first glance. But Removing it affects the display on the landing template while it doesn't on the default template (tested with Firefox).

On the landing template, removing it removes some spacing between "Read the page in:" and the list of languages when those are on the same line e.g. on https://www.w3.org/standards/about/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Issues related to the W3C website
Projects
None yet
Development

No branches or pull requests

3 participants