Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image links on feed display page #190

Closed
mcking65 opened this issue Feb 7, 2023 · 3 comments
Closed

Broken image links on feed display page #190

mcking65 opened this issue Feb 7, 2023 · 3 comments
Assignees
Labels
bug Something isn't working Infrastructure

Comments

@mcking65
Copy link
Contributor

mcking65 commented Feb 7, 2023

there is another issue which PR #187 doesn't address and we still have to fix: there are now broken image links in the feedDisplay page.

That example dynamically creates images, which, as of the release yesterday, is not something we support, because on the final deploy the images will be stored in a different directory than the source code. All of the content and assets for the entire site will be split up into three groups, a content folder for html files, a content-images folder for images, and a content-assets folder for everything else.

Personally, while the site does currently work, I think the mental overhead of making sure the APG supports its html, images and assets being automatically divided up into three directories when deployed is not a good long-term solution.

Originally posted by @alflennik in #186 (comment)

@mcking65
Copy link
Contributor Author

mcking65 commented Feb 7, 2023

@alflennik

With PR w3c/aria-practices#2417 we didn't make any changes that would have changed how images were referenced from the feed display page. So, how did this regression occur?

@mcking65 mcking65 added bug Something isn't working Infrastructure labels Feb 7, 2023
@alflennik
Copy link
Contributor

Hi @mcking65, the changes were in wai-aria-practices #187 and we edited the build scripts to split up the three types of content. Fortunately there were limited repercussions beyond the feed display example.

@mcking65
Copy link
Contributor Author

Fixed by w3c/aria-practices#2729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants