Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new technique for new contrast formula (threshold value) #1213

Closed
alastc opened this issue Jul 14, 2020 · 7 comments · Fixed by #1780
Closed

Create new technique for new contrast formula (threshold value) #1213

alastc opened this issue Jul 14, 2020 · 7 comments · Fixed by #1780

Comments

@alastc
Copy link
Contributor

alastc commented Jul 14, 2020

One approach to dealing with the updated colour contrast value is to add a new technique using the new value, making it a sufficient one for the contrast criteria.
https://www.w3.org/2020/07/14-ag-minutes.html#item07

@bruce-usab bruce-usab changed the title Create new technique for new contrast formula (exponent value) Create new technique for new contrast formula (threshold value) Jul 14, 2020
@bruce-usab
Copy link
Contributor

bruce-usab commented Jul 14, 2020

Deprecated formula is currently referenced in Note to glossary reference for relative luminance, see:
https://www.w3.org/TR/WCAG21/#dfn-relative-luminance

Three instances:

if RsRGB <= 0.03928 ...
if GsRGB <= 0.03928 ...
if BsRGB <= 0.03928 ...

Should be:

if RsRGB <= 0.04045 ...
if GsRGB <= 0.04045 ...
if BsRGB <= 0.04045 ...

See Issue #360 for the long version.

Here is a graphic of the formula from Issue w3c/wcag3#192

formula screen grab

@alastc
Copy link
Contributor Author

alastc commented Jul 15, 2020

Hi @bruce-usab, I think the task was to create a technique (maybe based on G18?) that would use the newer value.

That could be copy-paste G18 into a Google doc and highlight the updates you make, or:

  • Create a new branch (e.g. wcag22-contrast-technique)
  • Duplicate techniques/general/G18.html to contrast-update.html
  • Make the text changes.
  • Create a PR from that branch.

@bruce-usab
Copy link
Contributor

Thank you @alastc for that clear direction. My comment above was mostly to distill for myself the specifics of the discrepancy.

@alastc
Copy link
Contributor Author

alastc commented Jul 15, 2020

Sorry if I was 'process-splaining'! I'm just running through issue statuses and working out where things are.

@bruce-usab
Copy link
Contributor

No, that was helpful!

@bruce-usab
Copy link
Contributor

I have created PR #1223 using the correct threshold value.

@bruce-usab bruce-usab added Survey - Ready for Survey - Has pull request Don't put this in the survey, include the PR and removed Survey - Ready for labels Jul 21, 2020
@alastc
Copy link
Contributor Author

alastc commented Oct 14, 2020

Hi Andy,

That's just a WCAG 2.x update allowing for the use of the 'newer' value.

-Alastair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants