Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test is conflicting with the spec #202

Closed
arthuro555 opened this issue Apr 22, 2021 · 3 comments · Fixed by web-platform-tests/wpt#28654
Closed

Test is conflicting with the spec #202

arthuro555 opened this issue Apr 22, 2021 · 3 comments · Fixed by web-platform-tests/wpt#28654

Comments

@arthuro555
Copy link

Hello, I am not sure if this is the right place to talk about this, but one of the tests in the test suite specified in the specification document is testing against something conflicting with the specification. I am talking about this test. It is testing if it is possible to pass a data: url as parameter. However, the spec states under 2.1.2.8.4 that

If url's scheme is not "http" or "https", return a promise rejected with TypeError.

As it is returning, it will never reach step 11 where the URL is transmitted to target.

Did I misunderstand something in the specification in any way?

@saschanaz
Copy link
Member

saschanaz commented Apr 22, 2021

#174 added that step, it seems that test wasn't checked back then.

@ewilligers
Copy link
Collaborator

Many of the tests previously used data:

The spec restriction to http: or https: was only added recently - see #173.

The test can be updated to use https:

@marcoscaceres
Copy link
Member

Closed via web-platform-tests/wpt#28654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants