-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename lazyload.md to loading-frame-default-eager.md #293
Conversation
The policy is renamed accordingly.
|
||
The `loading-frame-default-eager` policy-controlled feature can be used for a main frame or a nested | ||
`<iframe>` to overwrite the default or assigned value of the newly | ||
introduced `loading` [attribute](https://github.com/whatwg/html/pull/3752) for `<iframe>` and `<img>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and <img>
? Weren't we discussing a separate policy for images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part defines what loading
attribute is; which is related to both <img>
and <iframe>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need to explain loading
-- this feels like it should be the introduction to loading-frame-default-eager
, so I parsed it incorrectly as "feature can be used ... to overwrite the default value ... for <iframe>
and <img>
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest version does not name <img>
.
Addressing clelland@'s comments.
Remove <img> reference.
|
||
The Extra Mile | ||
----------- | ||
In general the feature could allow an expanded set of enforcement policies with the use of [parametric features](https://github.com/WICG/feature-policy/issues/163). Under a geralized `loading-frame` policy, the following potential values could be supported (in the order of permissiveness): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geralized
"generalized"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
```HTTP | ||
Feature-Policy: loading-frame-default-eager 'none' | ||
``` | ||
would cause all the nested `<iframe>`'s and the corresponding nested and auxiliary browsing contexts to load lazily, unless the have specifically set `loading="eager"`. For example, if the document has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless the have specifically set
loading="eager"
"unless they have specifically set loading="eager"
"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reflect the changes (to be merged) in w3c#293.
Fix typos.
------------ | ||
With the `loading-frame-default-eager` attribute, developers could prioritize the loading of different inline frames on a web page. This however could become a cumbersome process and not quite scalable for larger | ||
web sites specially given that applying the attribute is origin-agnostic. The proposed policy aims to resolve | ||
this issue but changing a browser's default decision for `loading` behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed policy aims to resolve
this issue but changing a browser's default decision
"by changing a browser's..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These typos also exist in https://github.com/w3c/webappsec-feature-policy/pull/295/files ... >.<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done thanks. and yes it should definitely be sharing the same typos which I will tend to tomorrow.
Minor changes and typo fixes
* Change 'lazyload' to 'loading-frame-default-eager' Reflect the changes (to be merged) in #293.
The policy is renamed accordingly.