-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timestamp -> timeStamp? #156
Comments
I do think timestamp is more common, but changing for consistency SGTM. I'll block on resolution of #122 (hopefully soon). |
I note that Media Source Extensions uses |
I would note neither of those places uses "timestamp" as a variable name - in MSE, it's "start" and "end" and "timestampOffset" (the best proof of your point). In WebAudio, AudioTimestamp is a type - but you would use "getOutputTimestamp()", so kinda similar, but usually times are "start" and "end" and the like. By contrast, though, the DOMEvent "timeStamp" attribute is used pretty much everywhere (because most things that have associated time are events - or rather, Events - which have this attribute inherited). Web MIDI code, for example, will regularly refer to ".timeStamp" for MIDI events. |
It's spelled "timestamp" throughout the WebRTC spec, e.g. RTCRtpContributingSource, RTCStats, and throughout Identifiers for WebRTC's Statistics API. It's also "timestamp" in the Generic Sensor API spec, the Notifications API and a few other specs in earlier stages. I would argue that Event.timeStamp and the type names DOMTimeStamp and DOMHighResTimeStamp are the outliers here. |
we find the points about timestamp (no 'S') in other media apis compelling. editors resolved to keep it 'timestamp' |
Spinning off from #122... other places on the web platform use "time stamp" or
timeStamp
when in API form. Most notably, https://dom.spec.whatwg.org/#dom-event-timestamp .It's probably a good idea to stay consistent with the rest of the platform in this regard, and use
timeStamp
(ortimeStampMicroseconds
) instead oftimestamp
ortimestepMicroseconds
The text was updated successfully, but these errors were encountered: