Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ResourceType in network requests #704

Closed
OrKoN opened this issue Apr 29, 2024 · 4 comments
Closed

Support ResourceType in network requests #704

OrKoN opened this issue Apr 29, 2024 · 4 comments
Labels
enhancement New feature or request module-network Network module needs-discussion Issues to be discussed by the working group

Comments

@OrKoN
Copy link
Contributor

OrKoN commented Apr 29, 2024

CDP exposes Network.ResourceType which indicates what kind of resource is being loaded https://chromedevtools.github.io/devtools-protocol/tot/Network/#type-ResourceType

This type of information is commonly exposed in browser DevTools and, for example, Puppeteer also exposes it to the users so that users can perform analysis and interception based on the resource type detected by the browser.

The resourceType partially matches https://fetch.spec.whatwg.org/#concept-request-destination
@OrKoN OrKoN added enhancement New feature or request module-network Network module labels Apr 29, 2024
@whimboo whimboo added the needs-discussion Issues to be discussed by the working group label Apr 29, 2024
@OrKoN
Copy link
Contributor Author

OrKoN commented Apr 29, 2024

Related #698

@OrKoN
Copy link
Contributor Author

OrKoN commented Apr 29, 2024

ResourceType vs request destination https://docs.google.com/spreadsheets/d/15nwWRnflDT8ZuoEjRbu1xqhLDXReBc4y_hV3mrQo-VE/edit?usp=sharing

@mxschmitt mxschmitt mentioned this issue Sep 12, 2024
Open
42 tasks
@whimboo
Copy link
Contributor

whimboo commented Nov 8, 2024

FYI @jgraham pushed a PR as #809 which uses the initiatorType and destination from the fetch spec. Please let us know what you think. Thanks.

@whimboo
Copy link
Contributor

whimboo commented Nov 20, 2024

#809 is fixed.

@whimboo whimboo closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module-network Network module needs-discussion Issues to be discussed by the working group
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whimboo @OrKoN