-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_execute_action
, _execute_browser_action
and _execute_page_action
commands
#301
Comments
Thank you @carlosjeurissen ;) |
During our 2022-10-27 meeting, Chrome was not supportive of keeping multiple names alive due to the amount of resources this would cost. Support from Firefox is unknown. As for easing the migration from mv2 to mv3, this is not an issue in Safari, as they do currently not support commands. However, there was consensus between browsers this migration should be handled during the transition from mv2 to mv3. This can be tracked for Chrome in https://crbug.com/1353210 |
This issue is tracked in Firefox at https://bugzilla.mozilla.org/show_bug.cgi?id=1797811 |
Chromium has fixed the migration issue in https://bugs.chromium.org/p/chromium/issues/detail?id=1371857 . |
It looks like we can close this, as I would consider this a bug, and since the only issue left is a bug in Firefox, that has a tracking issue,. |
This has been fixed in Firefox 127. |
As reported by @beaufortfrancois in https://crbug.com/1371857, there are some issues related to the command to open webExtensions
action
.Background
In MV2, this classically was defined as
_execute_browser_action
and_execute_page_action
forbrowserAction
andpageAction
respectively. In MV3, both were renamed to_execute_action
.In the current situation, when a user set a certain shortcut in MV2 for
_execute_browser_action
, then upgrades to MV3 and renames it to_execute_action
, the shortcut is lost.Solution
Internally, browsers should threat
_execute_browser_action
,_execute_page_action
and_execute_action
all as equivalent and only store one custom shortcut from the user for all of them. If multiple are found, either stored by the browser, or multiple definitions in themanifest.json
commands
key, the_execute_action
would be preferred.To assist in the process, browsers should warn about the presence of
_execute_*
if the equivalentaction
key is not present, which would fix: https://crbug.com/1353210Tracking issue for Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1797811
The text was updated successfully, but these errors were encountered: