Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge browser compatibility issue: action.setTitle() #32

Closed
hanguokai opened this issue Jul 1, 2021 · 10 comments
Closed

Edge browser compatibility issue: action.setTitle() #32

hanguokai opened this issue Jul 1, 2021 · 10 comments
Labels
implemented: edge Implemented in Edge inconsistency Inconsistent behavior across browsers

Comments

@hanguokai
Copy link
Member

browserAction.setTitle() on Edge browser has a compatibility issue. It appends , ${badge_text} to title if the badge text is not empty. For example, if you set the badge text to "badge", and set title to "title", then the real title is "title, badge" on Edge browser.

It’s an unnecessary, smarty-pants behavior, and breaks compatibility. If developers want to set like that, they can set by themself. But Edge force to add badge text to title, developers have no way to remove them and can't show the same title on different browsers.

PS: If there is a issue on Chrome, I will report it to https://bugs.chromium.org/ . But I don't know where to report bug to Microsoft Edge.

@dotproto dotproto added the inconsistency Inconsistent behavior across browsers label Jul 7, 2021
@xeenon xeenon changed the title Edge browser compatibility issue: action.setTitle() Edge browser compatibility issue: action.setTitle() Jul 8, 2021
@MaheshKumarJha
Copy link

@hanguokai Thank you for your feedback. The reason why this is done for Edge is to make the badge accessible to users via narrator or other voice assistants.
The setTitle and getTitle still work with only the title - getTitle returns only the title part. Did you mean that tooltip shows "title, badge" in your comment above? Due to the accessibility part, whenever the badge is visible, it needs to be accessible since it is visually part of the action icon. So, its not an optional choice available to the developer as of now. Please let me know if you have any suggestions on how this can be changed to make it more developer friendly.

@hanguokai
Copy link
Member Author

setTitle

There is no problem with accessibility, the problem is that it should not be shown(see my screenshot above). Badge and Title are two different things, and two different UI parts. Now that the badge is displayed, why should it be repeatedly displayed on title? Users are very confused to see this extra thing if developer already set title.

I agree to provide accessibility. My suggestion:

  1. badge should not be shown in title, it should be a screen-reader-only(invisible) info.
  2. or badge and title are treat as two different things(not one thing) for accessibility.

@bcomnes
Copy link

bcomnes commented Jul 19, 2021

Agree @hanguokai. Accessibility should not be an excuse to degrade the overall experience, or an excuse to not implement proper accessibility features that don't degrade user experience. Forcefully inserting the badge value in the title appears really hacky (on top of being totally unexpected e.g. where is this random ", 8" coming from, an accessibility issue in and of itself).

@xeenon
Copy link
Collaborator

xeenon commented Aug 5, 2021

I agree that extensions should be in 100% control of what appears in the tooltip (title). The badge text should be exposed separately and internally to the screen reader.

@dhjw
Copy link

dhjw commented Feb 1, 2022

This behavior is ridiculous and I will not publish my extension for Edge because of it. How's that for accessibility?

@carlosjeurissen
Copy link
Contributor

@hanguokai Microsoft now provided us the right channels to report issues. See #155 and #155 (comment)

@dhjw
Copy link

dhjw commented Feb 5, 2022

I created a feedback here.

@carlosjeurissen
Copy link
Contributor

As this seems to be an edge-only issue, I'm closing this issue in favor of:
microsoft/MicrosoftEdge-Extensions#19

@hanguokai
Copy link
Member Author

Thanks @dhjw and @carlosjeurissen for reporting this issue in other places.

@hanguokai
Copy link
Member Author

This issue is now resolved in Edge browser. There is no redundant text in the title now.

@hanguokai hanguokai added the implemented: edge Implemented in Edge label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented: edge Implemented in Edge inconsistency Inconsistent behavior across browsers
Projects
None yet
Development

No branches or pull requests

7 participants