-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge browser compatibility issue: action.setTitle()
#32
Comments
action.setTitle()
@hanguokai Thank you for your feedback. The reason why this is done for Edge is to make the badge accessible to users via narrator or other voice assistants. |
There is no problem with accessibility, the problem is that it should not be shown(see my screenshot above). Badge and Title are two different things, and two different UI parts. Now that the badge is displayed, why should it be repeatedly displayed on title? Users are very confused to see this extra thing if developer already set title. I agree to provide accessibility. My suggestion:
|
Agree @hanguokai. Accessibility should not be an excuse to degrade the overall experience, or an excuse to not implement proper accessibility features that don't degrade user experience. Forcefully inserting the badge value in the title appears really hacky (on top of being totally unexpected e.g. where is this random ", 8" coming from, an accessibility issue in and of itself). |
I agree that extensions should be in 100% control of what appears in the tooltip (title). The badge text should be exposed separately and internally to the screen reader. |
This behavior is ridiculous and I will not publish my extension for Edge because of it. How's that for accessibility? |
@hanguokai Microsoft now provided us the right channels to report issues. See #155 and #155 (comment) |
I created a feedback here. |
As this seems to be an edge-only issue, I'm closing this issue in favor of: |
Thanks @dhjw and @carlosjeurissen for reporting this issue in other places. |
This issue is now resolved in Edge browser. There is no redundant text in the title now. |
browserAction.setTitle()
on Edge browser has a compatibility issue. It appends, ${badge_text}
to title if the badge text is not empty. For example, if you set the badge text to "badge", and set title to "title", then the real title is "title, badge" on Edge browser.It’s an unnecessary, smarty-pants behavior, and breaks compatibility. If developers want to set like that, they can set by themself. But Edge force to add badge text to title, developers have no way to remove them and can't show the same title on different browsers.
PS: If there is a issue on Chrome, I will report it to https://bugs.chromium.org/ . But I don't know where to report bug to Microsoft Edge.
The text was updated successfully, but these errors were encountered: