-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke activeTab from panel.onShown user interaction #386
Comments
I agree it’s kind of expected. A dev tool already has full access to the page via |
Agree with @fregante, this seams reasonable. |
I think the use case seems reasonable, but I'm not sure if |
It depends on what your bar is for "user gesture", but IMO it should be sufficient even if it feels awkward:
If the extension needs to inject content scripts in order to function ( and many do ), then IMO the developer who is installing the devtools extension will prefer a solution like this, eg they install a devtools extensions and it "just works" without extra steps. |
I'll be curious to hear which interactions you have in mind. 🙂 One use case my original proposal leaves out is a devtools extension that needs the Perhaps opening the devtools could invoke the |
As both a user and creator of DevTools extension, I would prefer if browser required more than
Is this really a problem in practice? Extension could display a UI to request host permissions for the site and then reload the page. This is very similar to the way "Network" tab works. Also, the performance profilers typically require page reload anyway.
This seems likely to be abused |
After some more discussion, we are supportive of this in Chrome. It's not something we are likely to prioritize short term, but makes sense given that DevTools already has the "Read and change all your data on all websites" warning. |
Developer tools extensions commonly need to inject a content script to set up communication between a page and a devtools panel. This task requires host permissions to permit the extension to inject the content script.
Using the
activeTab
permission would be preferable to limit the scope of required permissions. TheactiveTab
permission is invoked with the following user interactions:Would it be possible to add the
panel.onShown
event as a means of invoking theactiveTab
permission? It seems on par with the other user interactions. In particular, it is like executing an action.The text was updated successfully, but these errors were encountered: