Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setUninstallURL length update #399

Open
patrickkettner opened this issue May 29, 2023 · 0 comments
Open

setUninstallURL length update #399

patrickkettner opened this issue May 29, 2023 · 0 comments
Labels
implemented: chrome Implemented in Chrome implemented: firefox Implemented in Firefox neutral: safari Not opposed or supportive from Safari

Comments

@patrickkettner
Copy link
Contributor

Hiya folks!
There was a an issue on our mailing list recently, where folks brought up hitting the string limit in setUninstallURL. I pushed a CL to update this to 1023. For some reason I was thinking this was a chrome specific API, so I did not think to bring it to the group first. Apologizes for that. I dug into support elsewhere and found that Safari apparently did not enforce any length from what I could tell, and Firefox had to (up-until recently) same limit of 255. I submitted a PR to mozilla as well.

@Rob--W Rob--W added supportive: firefox Supportive from Firefox implemented: chrome Implemented in Chrome implemented: firefox Implemented in Firefox and removed supportive: firefox Supportive from Firefox labels Jun 7, 2023
@Rob--W Rob--W added neutral: safari Not opposed or supportive from Safari and removed needs-triage labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented: chrome Implemented in Chrome implemented: firefox Implemented in Firefox neutral: safari Not opposed or supportive from Safari
Projects
None yet
Development

No branches or pull requests

2 participants