-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency: proxy API #573
Comments
@erosman you have vast experience with proxy API, could you please provide some feedback on both APIs and on this idea? |
proxy.onRequestproxy.onRequest is a Firefox specific API and although it relates to proxying, it should be regarded as a separate area from
Firefox supports PAC file/script via proxy.settingsThere are a number of inconsistencies between chrome proxy.settings & Firefox proxy.settings and I have already filed a number of issues here and on Bugzilla accordingly. 1. Proxy Bypass listInconsistency: Proxy Bypass list
2. IncognitoInconsistency: incognito in proxy.settings
3. QUIC (HTTP/3) scheme in proxy
4. proxy.settings API ComparisonThere are considerable differences between the properties and value formats of
|
re: inclusionList inclusionList would be a new feature request and would better be discussed independently. |
@erosman thank you for the very detailed list of differences! Regarding the inclusion list, it is indeed a new feature request, I just don't understand where to file it. Anyways, it is indeed off-topic here, I'll move it later to a more correct place. |
Removing the Chrome needs-triage label. We are generally supportive of aligning here where it makes sense, but based on discussion at the in-person meeting, it seems the most actionable work is for Firefox to investigate supporting the declarative style API. inclusionList sounds interesting but would need a separate API proposal. |
This topic was discussed during the WECG in-person meeting.
First of all, proxy extensions is one of the most popular extensions category on both CWS and Mozilla add-ons store with hundreds of popular extensions available.
Both Chrome and Firefox provide proxy API which are very different. Firefox API is based on the
proxy.onRequest
callback and it is more powerful, but it goes against Chrome’s approach of getting rid of blocking callbacks. Implementing Chrome's interface would allow Firefox to benefit from having more extensions available that use non-blocking API.Links to the documentation
Chrome API example
Firefox API example
Notable differences
Off-topic about `inclusionList`
inclusionList
In addition to that (I may need to open a separate issue or just open it in Chrome's bug tracker). Currently, we are forced to use an auto-generated PAC script in Chrome as the current API lacks the ability to configure an "inclusion list". PAC script generation is far from ideal and prone to errors so I suggest adding a new
inclusionList
field toProxyRules
.If
inclusionList
is not empty then requests to the hostname should only be sent over the proxy when that hostname is in theinclusionList
.inclusionList
should support the same syntax asbypassList
.Pseudo-code for the requested logic:
The text was updated successfully, but these errors were encountered: