-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use match_origin_as_fallback
behavior by default in scripting.executeScript
#673
Comments
MV3 executeScript uses kMatchForAboutSchemeAndClimbTree to mimic MV2 executeScript, I guess. MV3 registerContentScripts uses kAlways and exposes Hence, maybe it would make more sense to expose |
@kiaraarose Could you confirm Safari's behavior and set it to
implemented: safari
|
I've filed a Chromium issue to track this work here: https://issues.chromium.org/363031548 |
Safari will not inject into a frame if permissions are not granted, and currently permissions are only granted based on HTTP-family URL patterns. An We are supportive of this issue and would implement it once we have |
Kiara mentioned that Safari does currently not inject in about:blank, and that support for |
FYI: During TPAC 2024 (#659) I sat together with Oliver and he created a patch to implement this in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5890628 Once that is approved and merged, the chrome label on this issue can be updated and the ticket be closed. |
In Manifest V2, the
tabs.executeScript
method has amatchAboutBlank
property which matches the behavior ofmatch_about_blank
in the manifest.In Manifest V3, the
scripting.executeScript
method in Chrome applies this behavior by default. We chose this since the API is more explicit about the injection target, and therefore there is clearer intent from the developer to inject into a given frame.However, since then we have introduced
match_origin_as_fallback
. We'd like to make that the default forscripting.executeScript
. This will need some communication, since it's technically a behavior change, but should be low impact.The text was updated successfully, but these errors were encountered: