Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I hope browsers can provide an API to hide/show the bookmarks bar and pinned api #689

Closed
cunzaizhuyi opened this issue Sep 18, 2024 · 5 comments
Labels
enhancement Enhancement or change to an existing feature opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox opposed: safari Opposed by Safari topic: browser settings

Comments

@cunzaizhuyi
Copy link

I have developed a plugin that can hide the browser extension list with one click, thereby protecting your privacy. It is very useful in certain scenarios, such as:

  • When developers are doing technical sharing
  • When professionals are sharing their screens
  • When content creators start recording videos
    However, this is not enough. It would be even more helpful if we could hide the bookmarks bar along with the browser extension list.

Currently, due to browser security restrictions, it is not possible to hide the bookmarks bar.

Therefore, I hope browsers can provide an API to hide/show the bookmarks bar.

The plugin is open-source, and the code repository is here: https://github.com/cunzaizhuyi/up-mode-extension

The plugin is already online, and you can install it from the Chrome Web Store: https://chromewebstore.google.com/detail/up-mode/maiiinianakmklepgbpffmgmhpnoniem?hl=zh-CN&utm_source=ext_sidebar

@github-actions github-actions bot added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time labels Sep 18, 2024
@DeltaView
Copy link

well, you can hide bookmarks bar manually. Use keyboard command CTRL + Shift + B on Windows to toggle it. You can also right click on the bookmarks bar and unselect the corresponding option.

@fregante
Copy link

Having dedicated browser profiles or better yet operating system profiles is usually preferable, as it’s comprehensive and built-in.

@dotproto dotproto added the enhancement Enhancement or change to an existing feature label Sep 18, 2024
@dotproto
Copy link
Member

@cunzaizhuyi, I just took a glance at your extension. If I'm reading the source correctly, you're currently using management.setEnabled() to hide/show extensions. This may have unintended side effects as disabling extensions stops them from working. If a user is relying on a privacy or security extension, disabling the extension may put the user at risk.

It looks like this use case has two feature requests:

  1. Allow extensions to manage the pinned state of other extensions.
  2. Allow extensions to control the visibility of the bookmark toolbar.

Request (1) could potentially be addressed through the introduction of a new method on the management namespace such as setPinned(). This could be modeled after the existing setEnabled() method.

Request (2) could potentially be addressed through the introduction of a new property on the browserSettings namespace (currently Firefox-only) such as showBookmarksToobar.

@cunzaizhuyi
Copy link
Author

@cunzaizhuyi, I just took a glance at your extension. If I'm reading the source correctly, you're currently using management.setEnabled() to hide/show extensions. This may have unintended side effects as disabling extensions stops them from working. If a user is relying on a privacy or security extension, disabling the extension may put the user at risk.

It looks like this use case has two feature requests:

  1. Allow extensions to manage the pinned state of other extensions.
  2. Allow extensions to control the visibility of the bookmark toolbar.

Request (1) could potentially be addressed through the introduction of a new method on the management namespace such as setPinned(). This could be modeled after the existing setEnabled() method.

Request (2) could potentially be addressed through the introduction of a new property on the browserSettings namespace (currently Firefox-only) such as showBookmarksToobar.

Yes, you have understood my two needs very accurately.

In fact, I used the setEnabled() API because I couldn't find the setPinned() API.
If browsers implemented the setPinned() API, I would certainly be willing to use it.

@xeenon xeenon added neutral: safari Not opposed or supportive from Safari and removed needs-triage: safari Safari needs to assess this issue for the first time labels Sep 24, 2024
@Rob--W Rob--W added opposed: chrome Opposed by Chrome opposed: safari Opposed by Safari opposed: firefox Opposed by Firefox and removed neutral: safari Not opposed or supportive from Safari needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time labels Sep 24, 2024
@xeenon xeenon added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time and removed opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox labels Sep 24, 2024
@Rob--W Rob--W added opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox and removed needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time labels Sep 24, 2024
@rdcronin
Copy link
Contributor

This was one of the issues we discussed at TPAC.

While we fully recognized the utility of this function (the idea of an extension that can give you a "clean slate" for recordings or screen sharing makes perfect sense!), we all agreed this wasn't something we wanted to expose to extensions. Though extensions do have a number of capabilities to adjust settings, we didn't think allowing an extension to override this type of user setting was desirable.

Since all browsers are opposed to introducing this feature, I'm going to close this out.

@cunzaizhuyi cunzaizhuyi changed the title I hope browsers can provide an API to hide/show the bookmarks bar. I hope browsers can provide an API to hide/show the bookmarks bar and pinned api Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or change to an existing feature opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox opposed: safari Opposed by Safari topic: browser settings
Projects
None yet
Development

No branches or pull requests

7 participants