-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect application of "domainType: thirdParty" in DNR - blocking direct access to iana.org when opening a new tab #731
Comments
Also, there is another case, when we trying to convert our rule
to DNR format:
And in this example i also cannot open facebook.com from address bar. |
I don’t know the actual implementation, but it seems that when a user enters a URL into the address bar, the origin of the request is considered I believe it would be better if the URL were considered as originating from itself in such cases, if possible. This would resolve issues related to |
If extensions are not already relying on the current behavior for "domainType", Firefox would be willing to change it. For example, we could consider a different domainType other than "firstParty" and "thirdParty" for (main_frame) requests without initiator. Additional context: Firefox ultimately chose to follow Chrome's implementation, described at https://bugzilla.mozilla.org/show_bug.cgi?id=1797408#c6 , fully quoted below:
Note: I'm aware that DNR does currently not have the ability to filter by absent or opaque/null origin. I have written about the issue before at https://bugzilla.mozilla.org/show_bug.cgi?id=1798225 |
Description:
I have encountered an issue where the DNR incorrectly applies rule with
domainType: thirdParty
, leading to the blocking of direct access toiana.org
when opening it in a new tab, when this is a first-party request. As well as opening this site fromexample.org
, when it is a true third-party request.Steps to Reproduce:
dummy-extension-chrome.zip
dummy-extension-firefox.zip
Expected Behavior:
iana.org
should not be classified as a third-party domain when the user directly accesses it via the address bar.Actual Behavior:
When accessing
iana.org
from address bar, it is being blocked as well as opening it from 'example.com'Browser Details:
Tested on
The text was updated successfully, but these errors were encountered: