Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated void support #784

Open
nektro opened this issue Jun 27, 2024 · 5 comments
Open

Remove deprecated void support #784

nektro opened this issue Jun 27, 2024 · 5 comments

Comments

@nektro
Copy link

nektro commented Jun 27, 2024

https://github.com/w3c/webidl2.js/blob/83fffdb/test/invalid/idl/void-keyword.webidl#L1-L4

removed here whatwg/webidl#906

@saschanaz
Copy link
Member

Hmm? That's literally "invalid" idl 👀

@saschanaz
Copy link
Member

But it's true that it's overdue of this void thing, I'll remove the void support completely. I don't think that specific test will change, though.

@nektro
Copy link
Author

nektro commented Jun 27, 2024

right but since void isnt a keyword anymore its validly parsed as an identifier (granted one that doesnt match to anything, but that would only be found out at a later step) (i suppose the validator here could be doing that but mine wasn't which is what led to the confusion)

Definitions
Definition
CallbackOrInterfaceOrMixin
InterfaceOrMixin
InterfaceRest
InterfaceMembers
InterfaceMember
PartialInterfaceMember
Operation
RegularOperation
Type
SingleType
DistinguishableType
identifier

@nektro
Copy link
Author

nektro commented Jun 27, 2024

similar to how the following passes on https://w3c.github.io/webidl2.js/checker/

[Exposed=Window]
interface Foo {
  Bar foo();
};

@saschanaz
Copy link
Member

Oh right, yes. Good point, thank you.

@saschanaz saschanaz changed the title out of date test: void keyword Remove deprecated void support Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants