Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should it be possible to disable transforms on the fly? #142

Closed
fippo opened this issue Jul 27, 2022 · 2 comments
Closed

should it be possible to disable transforms on the fly? #142

fippo opened this issue Jul 27, 2022 · 2 comments

Comments

@fippo
Copy link
Collaborator

fippo commented Jul 27, 2022

from https://bugs.chromium.org/p/chromium/issues/detail?id=1347309

while I would 😍 to see this feature I think it is pretty hard to implement and does not offer much value over setting an identity transform.

Should we reject a change in the value using setConfiguration with a InvalidModificationError?
(also we seem to have lost the RTCConfiguration option somehow...)

@youennf
Copy link
Collaborator

youennf commented Jul 27, 2022

@fippo, you are probably referring to Chrome current implementation which is based on an earlier draft of this spec.
Since then, we moved to a different model, which supports disabling transforms and does not require any RTCConfiguration option.

@fippo
Copy link
Collaborator Author

fippo commented Jul 27, 2022

true, will add to #111

@fippo fippo closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants