Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RTP timestamp to metadata #169

Open
fippo opened this issue Dec 2, 2022 · 3 comments
Open

add RTP timestamp to metadata #169

fippo opened this issue Dec 2, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@fippo
Copy link
Collaborator

fippo commented Dec 2, 2022

see also #116

https://w3c.github.io/webrtc-encoded-transform/#RTCEncodedVideoFrame-interface
and
https://w3c.github.io/webrtc-encoded-transform/#RTCEncodedAudioFrame-interface
both define a timestamp as

readonly attribute unsigned long timestamp;

which by definition is the RTP timestamp (and this was changed to align with implementations).
This is different from what we have in Webcodecs

  readonly attribute long long timestamp;          // microseconds

This is hard to fix so we should do this as follows:

  • add rtpTimestamp to metadata
  • deprecate the existing timestamp on Encoded*Frame
  • remove from implementations for 1+ release
  • re-add with correct type
@aboba
Copy link
Contributor

aboba commented Apr 6, 2023

rtpTimestamp is already defined in VideoFrameCallbackMetadata so it seems logical to have it also be a property of encoded chunks in both Encoded Transform and WebCodecs.

@fippo
Copy link
Collaborator Author

fippo commented Apr 24, 2023

@tonyherre FYI

@tonyherre
Copy link
Contributor

To update on what's been happening: #173 added the long long timestamp type into the Metadata, so we at least now have that field matching the webcodecs field in both type and definition.
I created #203 to move the RTP timestamp to metadata and rename it to explicitly be rtcTimestamp - so the first bulletpoint in fippo's original comment.

@jan-ivar jan-ivar added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants