Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not specifying scaleResolutionDownTo if encoding is inactive #227

Closed
henbos opened this issue Oct 23, 2024 · 0 comments · Fixed by #228
Closed

Allow not specifying scaleResolutionDownTo if encoding is inactive #227

henbos opened this issue Oct 23, 2024 · 0 comments · Fixed by #228

Comments

@henbos
Copy link
Collaborator

henbos commented Oct 23, 2024

The text currently says to throw if "scaleResolutionDownTo is not specified on all encodings", but this is overly restricting, it should instead say "all active encodings".

It is common for an app to use the sender for both singlecast and simulcast so {720p,inactive,inactive} is a common use case and it doesn't really make sense to force the app to put in dummy scaleResolutionDownTo values on the inactive layers in order to avoid an exception. Restricting the resolution of an inactive encoding is a NO-OP so it couldn't possibly matter which value you plug in there, therefore it should be allowed to be missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant