Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of RTCRtpEncodingParameters.maxFramerate for audio encodings is probably underspecified #2793

Closed
docfaraday opened this issue Oct 26, 2022 · 2 comments · Fixed by #2799
Closed

Handling of RTCRtpEncodingParameters.maxFramerate for audio encodings is probably underspecified #2793

docfaraday opened this issue Oct 26, 2022 · 2 comments · Fixed by #2799
Assignees
@jan-ivar

Comments

@docfaraday
Copy link
Contributor

Right now, we do not do anything if content sets a maxFramerate on an audio RTCRtpEncodingParameters. We probably either want to unset it (like we do for scaleResolutionDownBy), or throw some sort of error.
@jan-ivar jan-ivar self-assigned this Nov 16, 2022
@jan-ivar jan-ivar mentioned this issue Nov 16, 2022
Merged
@jan-ivar
Copy link
Member

jan-ivar commented Nov 16, 2022 •
edited
Loading

It seems to me we should be consistent with scaleResolutionDownBy here, the other video-only parameter.

@docfaraday
Copy link
Contributor Author

Seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-ivar jan-ivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove maxFramerate like scaleResolutionDownBy for audio. jan-ivar/webrtc-pc
2 participants
@docfaraday @jan-ivar