Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTransportError.isInitiatedByClient #317

Open
yutakahirano opened this issue Jul 26, 2021 · 3 comments
Open

WebTransportError.isInitiatedByClient #317

yutakahirano opened this issue Jul 26, 2021 · 3 comments
Assignees

Comments

@yutakahirano
Copy link
Contributor

I think it'd be benefitial to have this boolean attribute in WebTransportError.

The attribute returns whether the error comes from the client. This will allow the script author to distinguish whether the stream (or session? There is no way to abort a session/connection from the script I believe, though...) is aborted because of the abort request from the client, or some issues in the server or network.

I don't know which milestone is appropriate - On the one hand, this is a nice to have. On the other hand, we may want to check this attribute in cancelArgorithm and abortAlgorithm, and that will be an incompatible change and hence we may want to do that before in the initial release.

What do you think?

@yutakahirano yutakahirano added the Discuss at next meeting Flags an issue to be discussed at the next WG working label Jul 26, 2021
@vasilvv
Copy link
Contributor

vasilvv commented Jul 28, 2021

This would make sense, as we have similar boolean in our QUIC API. One thing I will note though is that it should be possible to communicate this information via errorSource field (or whatever we call it), so we have two approaches here to choose from.

@jan-ivar
Copy link
Member

jan-ivar commented Aug 3, 2021

Meeting:

  • Preference for enum
  • Open to bikeshedding further. something = "client" | "server" ? initiator not the best since clients don't technically initiate errors, they just happen
  • A nice to have

@jan-ivar jan-ivar added this to the Sometime in the Future milestone Aug 3, 2021
@yutakahirano yutakahirano removed the Discuss at next meeting Flags an issue to be discussed at the next WG working label Aug 4, 2021
@jan-ivar
Copy link
Member

jan-ivar commented Sep 1, 2021

(or session? There is no way to abort a session/connection from the script I believe, though...)

The script can call wt.close(closeInfo). But I don't think this spec should solve a script not knowing it did that.

I'm tempted to say the same about client stream errors from stream.abort(new WebTransportError({streamErrorCode})).

@wilaw wilaw added Discuss at next meeting Flags an issue to be discussed at the next WG working and removed Discuss at next meeting Flags an issue to be discussed at the next WG working labels Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants