Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rateControlFeedbackMinInterval is unused #475

Closed
jan-ivar opened this issue Feb 22, 2023 · 1 comment
Closed

rateControlFeedbackMinInterval is unused #475

jan-ivar opened this issue Feb 22, 2023 · 1 comment

Comments

@jan-ivar
Copy link
Member

As mentioned in #421 (comment), the algorithm to update [[SendRate]] , which also fires the ratecontrolfeedback event, contains no throttling.

We need a [[RateControlFeedbackMinInterval]] internal slot, and update this algorithm to respect it.

Presumably this interval limits how often the sendRate is updated, and not just the firing of the event, otherwise the event isn't needed.
@wilaw
Copy link
Contributor

wilaw commented Mar 1, 2023

Closing favor of #484

@wilaw wilaw closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilaw @jan-ivar