Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request review of (text only) Async Clipboard API #222

Closed
3 of 5 tasks
garykac opened this issue Jan 5, 2018 · 16 comments
Closed
3 of 5 tasks

Request review of (text only) Async Clipboard API #222

garykac opened this issue Jan 5, 2018 · 16 comments
Assignees

Comments

@garykac
Copy link

garykac commented Jan 5, 2018

Hello TAG!

I'm requesting a TAG review of:

Further details (optional):

You should also know that...

This review is only for the text parts of the API since we are still in the process of designing the portions of the API that add clipboard support for images and delayed content generation.

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]
@garykac
Copy link
Author

garykac commented Jan 5, 2018

Note: We'll have a separate TAG review for the image/delayed-gen portions once we have general agreement on the specification

@slightlyoff
Copy link
Member

@torgo torgo added this to the tag-f2f-london-2018-01-31 milestone Jan 31, 2018
@chrishtr
Copy link

Hi is there any feedback on this API? I see labels for possible review in the f2f in London?

@owencm
Copy link

owencm commented Feb 12, 2018

(also just for context, this API is currently targeting a launch in M66 which branches on March 1st, so if there are any concerns, it'd be great to hear them ASAP)

@travisleithead
Copy link
Contributor

In looking through the minutes, it looks like we triaged, but didn't get a chance to discuss this :( So the short--no we don't have any feedback [yet] on this API.

@slightlyoff
Copy link
Member

Had a few rounds of follow-up with @garykac et. al. over on blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/epeaao7l13M/edF5Ho9PBgAJ

The explainer is in a much better place now, which I'm pretty happy about. I have concerns with the spec regarding image formats, introspection of available types, but those aren't being discussed to ship. We got to agreement to continue the discuss on those points here and it looks like Blink is moving forward with shipping the text-only portions.

@torgo
Copy link
Member

torgo commented Apr 7, 2018

My concern re: privacy considerations - the response to the self-review doesn't appear to take the privacy issues seriously enough in my view. Lots of private info can be in the clipboard and we should be very very careful before allowing access to it without explicit user consent. Arguably a permission approach does not cover it as once the permission is granted it is not visible to the user what is happening. Arguably it goes against user expectation if the webapp can gain access to the clipboard without affirmative user action (passively). Also arguably the behaviour should be different in private / incognito mode due to these privacy considerations.

@hadleybeeman
Copy link
Member

What worries me is that we've all spent a lot energy encouraging users to use password managers, which often rely on pasting passwords in to a form. If an open tab is able to inspect the contents of my clipboard, thereby giving away the password that I've copied... this seems concerning to me. How can we mitigate that here?

@triblondon
Copy link

Attempt to consolidate TAG feedback on privacy concerns:

We are generally very concerned about the potential for passive monitoring of the clipboard contents, which could easily capture passwords. We would like to encourage implementations to be as conservative as possible in their attempts to prevent this, and wonder if mechanisms such as these have been considered:

  • time limited grants for user consents
  • requirement for document focus to allow access to APIs methods
  • requirement for user interaction for paste API
  • expiration of permission on some event, eg defocus of window, navigation away from page

@dbaron
Copy link
Member

dbaron commented Apr 7, 2018

I'd also note that even if these things aren't normatively required, they should be discussed in the security considerations section of the spec.

@cynthia
Copy link
Member

cynthia commented Apr 7, 2018

Ditto on @dbaron 's comment above. Extra emphasis would be to mention unfocused tab reading being disallowed, since that seems to be how it is implemented in Canary.

Another thing that we touched on during the review is that the special case API for text seems something we may regret in the future. read() ideally should be the single interface for reading out of the clipboard (believe this was brought up during the I2S), whether or not individual types read out of the clipboard should be different levels of permission is up for discussion.

Extensibility to allow arbitrary types/objects for content which can be serialized for objects to cross web application boundaries would help a lot of non-text editing application use cases. (e.g. Copy and pasting between two different tabs running web based CAD software, for one example - comes to mind.)

Personal question: The choice of DataTransfer for non-text seems a bit strange. Aside from "it was already there, and was the closest thing to what we needed" were there any compelling reasons for this choice?

@torgo torgo added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Apr 24, 2018
@travisleithead
Copy link
Contributor

travisleithead commented May 8, 2018

I think we are looking specifically for responses on:

@torgo
Copy link
Member

torgo commented May 8, 2018

Discussed on call 5-8

@slightlyoff
Copy link
Member

hey @garykac; seems like we keep discussing this without you. My apologies! Would you be up for joining a future call to talk through the details?

@garykac
Copy link
Author

garykac commented May 8, 2018

Sure. Next Tue at 8am works. Do you meet only on IRC or is it a conference call?

@cynthia
Copy link
Member

cynthia commented May 15, 2018

Raised w3c/clipboard-apis#78 as a follow-up from May 15 telco.

@plinss plinss closed this as completed May 15, 2018
@cynthia cynthia removed the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label May 15, 2018
@torgo torgo mentioned this issue Oct 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests