Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making the "total" field optional in PaymentRequest API #512

Closed
maxlgu opened this issue May 4, 2020 · 18 comments
Closed

making the "total" field optional in PaymentRequest API #512

maxlgu opened this issue May 4, 2020 · 18 comments
Assignees
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it Review type: later review Topic: payments Venue: Web Payments WG

Comments

@maxlgu
Copy link

maxlgu commented May 4, 2020

Hello TAG!

I'm requesting a TAG review of making the "total" field optional in PaymentRequest API.

Given that when Digital Goods API is used with PaymentRequest API, the total amount is unnecessary, we propose to make the “total” field optional in PaymentRequest API spec, along with a few consequent changes.

@torgo torgo added this to the 2020-05-11-week milestone May 12, 2020
@kenchris
Copy link

This looks very sensible to me. No further comments from my side

@cynthia
Copy link
Member

cynthia commented May 12, 2020

LGTM2.

@cynthia cynthia added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Resolution: satisfied The TAG is satisfied with this design and removed Priority: urgent labels May 12, 2020
@hober hober self-assigned this May 12, 2020
@hober
Copy link
Contributor

hober commented May 12, 2020

This statement seems wrong:

Payment Request by itself is inadequate for making in-app purchases in existing digital stores, because that API simply asks the user to make a payment of a certain amount

But in Payment Request they can describe the item being purchased and have that description shown alongside the price. Certainly, users want to see both product names and prices. “Please authorize the purchase of SHINY_SWORD” without saying how much SHINY_SWORD costs seems wrong to me.

@maxlgu
Copy link
Author

maxlgu commented May 12, 2020

Hi @hober ,

Note that whether the total is optional or not, it's up to the payment apps to decide whether to show the total price - this proposal doesn't change this behaviour. Whether before or after the proposal, if the payment apps would like to over-charge the users (more than the requested total amount), they can do that. After all, it's the payment apps who have the access to the users' wallets. Also because of that, they would need to show the final charge to the users before the transaction so as to maintain the users' trust.

@aestes
Copy link

aestes commented May 12, 2020

Rather than making total optional, can the existing pending boolean on PaymentItem be used to support this use case?

For cases like ride sharing, where the total amount is unknown at the time of payment authorization, the total item can be marked as pending. In Apple Pay, for instance, the payment sheet will not display pending amounts.

Seems like if we support both pending totals and optional totals, it becomes more difficult for authors to understand which mechanism is appropriate for a given scenario.

@dbaron dbaron changed the title requesting a TAG review of making the "total" field optional in PaymentRequest API making the "total" field optional in PaymentRequest API May 13, 2020
@torgo torgo modified the milestones: 2020-05-11-week, 2020-05-21-f2f May 13, 2020
@hober
Copy link
Contributor

hober commented May 28, 2020

@maxlgu, any thoughts on @aestes' comment above?

@cynthia cynthia added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label May 28, 2020
@rsolomakhin
Copy link

Let's loop in @danyao and @mgiuca who have been having similar conversations in such places as w3c/payment-request#912.

@rsolomakhin
Copy link

And WICG/digital-goods#5.

@maxlgu
Copy link
Author

maxlgu commented May 29, 2020

@aestes : pending total makes sense only for the use case where the final price charged will be determined at some point in the future, like authorizing a payment for a service such as Uber.
Optional total makes sense when the total is already known to the payment app, which has just provided it to the merchant through the digital goods API.

@mgiuca
Copy link

mgiuca commented Jun 1, 2020

I agree @maxlgu . It sounds like "pending" has very different semantics to when total would be omitted because it is already known to the server.

@maxlgu maxlgu closed this as completed Jun 1, 2020
@maxlgu maxlgu reopened this Jun 1, 2020
@plinss plinss removed the Progress: propose closing we think it should be closed but are waiting on some feedback or consensus label Jun 10, 2020
@plinss plinss added this to the 2020-06-15-week milestone Jun 10, 2020
@maxlgu
Copy link
Author

maxlgu commented Jun 11, 2020

Since the main argument of this feature is for the digital good api, this tag review should merge into that one once it exists. Set this tag review as blocked.

@cynthia cynthia added Progress: blocked on dependency Paused while some other design review finishes up. and removed Resolution: satisfied The TAG is satisfied with this design Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review labels Jun 15, 2020
@kenchris
Copy link

Hi there, any update on this and the Digital Goods API? Will that be send to TAG review anytime soon?

@maxlgu
Copy link
Author

maxlgu commented Sep 23, 2020

This was blocked on @mgiuca 's work on the Digital Goods API.

@mgiuca , what's the status of the Digital Goods API?

@mgiuca
Copy link

mgiuca commented Oct 12, 2020

Apologies for leaving this one. I thought we had already discussed Digital Goods in TAG, but it seems it was only in the context of this one issue.

We will open a TAG review for DG.

@plinss plinss removed this from the 2020-09-21-F2F-Cork milestone Oct 14, 2020
@phoglenix
Copy link

phoglenix commented Nov 16, 2020

TAG review opened for Digital Goods API: #571

@kenchris
Copy link

@hober did you have any issues with this review issue? It has a dep on Digital Goods, but it would be good to close, if you don't

@kenchris
Copy link

@hober this seems to be depending on you? :-) Can you have a look so that we can potentially close this

@cynthia
Copy link
Member

cynthia commented Sep 14, 2021

We apologize this took so long - we think this has past it's due date, and the other reviewers were happy with this. We are going to close this in the rollups of our VF2F today.

@cynthia cynthia added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it and removed Progress: blocked on dependency Paused while some other design review finishes up. labels Sep 14, 2021
@torgo torgo closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it Review type: later review Topic: payments Venue: Web Payments WG
Projects
None yet
Development

No branches or pull requests

10 participants