Pre-CR review: DOM Review Draft — Published 21 June 2021

[siusin]

Ya ya yawm TAG!

I'm requesting a TAG review of DOM Review Draft — Published 21 June 2021.

The WHATWG published a new Review Draft of the DOM Standard on 21 June 2021. The HTML WG plans to take the latest Review Draft to W3C Recommendation in September, thus we are inviting another wide and horizontal review of the commits of the DOM Standard between Jun 2020 and Jun 2021.

• Specification URL: https://dom.spec.whatwg.org/review-drafts/2021-06/
• Tests: wpt/dom
• GitHub repo (if you prefer feedback filed there): https://github.com/whatwg/dom/issues
• Primary contacts (and their relationship to the specification):
  • @hober , HTML WG co-chair
  • @sideshowbarker
  • WHATWG DOM editors
• Organization(s)/project(s) driving the specification: WHATWG & W3C
• Key pieces of existing multi-stakeholder review or discussion of this specification:
  Wide Review for the DOM Review Draft — Published 21 June 2021

Further details:

• Relevant time constraints or deadlines: 2021-08-31
• The group where the work on this specification is currently being done: WHATWG and W3C HTML WG
• The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): WHATWG and W3C HTML WG
• This work is being funded by: WHATWG and W3C

We put together a list of significant changes, please pay attention to these pull requests during your group discussion:

• whatwg/dom@12beda2
  DOM Events introduction: clarify how listeners are invoked

• whatwg/dom@f837ce1
  Add "precustomized" custom element state

• whatwg/dom@8c0049e
  Add "is available to element internals"

• whatwg/dom@52f7a52
  Need to catch exceptions to report them

• whatwg/dom@83037a1
  Add signal support to addEventListener()

• whatwg/dom@aa384af
  Add AbortSignal.abort() static method

• whatwg/dom@c80cbf5
  Use a single exception for name validation (follow-up)

• whatwg/dom@acfe96b
  Add imperative slot assignment API

• whatwg/dom@d2c84ec
  Add the IDL of XSLTProcessor

• whatwg/dom@f346858
  Add ShadowRoot.prototype.delegatesFocus attribute

[LeaVerou]

Hi @siusin,

@plinss and looked at this today during our virtual f2f.

We had some questions:

• We see references to a new "precustomized" state for custom elements, but we did not find a definition of what this state means, and how do you get there. It seems to be completely undefined.
• There is an "is available to element internals" flag, but no definition of what it means
• If shadowRoot is available to internals, is there a difference between this.shadowRoot and this.internals.shadowRoot or do they point to the same thing?
• We see a new delegatesFocus property has been added on ShadowRoot, but there is no description of what it's supposed to do. By looking around we found this, but it's still unclear what use cases it solves and what exactly it does.

The rest of the changes seem fine.

[annevk]

Could you please file these as issues against whatwg/dom? Seems most of these should be easy to clarify with a couple of notes. Thanks!

[LeaVerou]

We posted them as questions here first in case they are explained somewhere in the spec and we just missed it. If not, we can definitely make new issues.

[annevk]

I think for "precustomized" there is a note that explains its purpose. It's essentially an implementation detail.

The others could do with some notes I think.

FWIW, this.internals.shadowRoot can point to a closed shadow tree. In which case this.shadowRoot would return null. In retrospect perhaps shadow roots should only have been exposed on custom elements, but not everyone is of that opinion.

[LeaVerou]

Hi @siusin, apologies for the late reply. We have provided some feedback above, but overall this looks good to us. We also understand this is widely implemented by now, which reduces the impact any review could have. Spec diffs are not an explainer, and do not contain the information we need to review.

Furthermore, after discussing this in a breakout today (present: @cynthia @rhiaro and me) we do not think it's productive to do such large reviews, at such a late stage. They demand a lot of resources, but it's too late for the effort to make a meaningful difference. Please instead ask for reviews of individual features earlier, before they are so widely implemented.

[annevk]

Will you still file issues for the desired clarifications?

[rhiaro]

I've copied Lea's questions over to the WHATWG DOM repo issues. Please feel free to close them if/when you resolve them without waiting for anything further from our end.

[annevk]

🙏🏻