Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Transition Classes #938

Closed
1 task done
vmpstr opened this issue Feb 22, 2024 · 14 comments
Closed
1 task done

View Transition Classes #938

vmpstr opened this issue Feb 22, 2024 · 14 comments
Assignees
Labels
Focus: Accessibility (pending) Focus: API design (pending) Mode: breakout Work done during a time-limited breakout session Progress: review complete Resolution: decline The TAG declines to review this work. We don't think our review would add much. We don't object. Topic: accessibility Topic: CSS Venue: CSS WG

Comments

@vmpstr
Copy link

vmpstr commented Feb 22, 2024

こんにちは TAG-さん!

I'm requesting a TAG review of View Transition Classes.

This feature introduces a new CSS property view-transition-class which allows the developer to specify one or more view transition classes. The developer can then select the ViewTransition pseudo elements using these classes (e.g. ::view-transition-group(*.class)).

This is an extension to the ViewTransition API that simplifies styling of view transition pseudo elements in a similar way that CSS classes simplify styling of regular DOM elements.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: None.
  • The group where the work on this specification is currently being done: CSSWG.
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): CSSWG.
  • Major unresolved issues with or opposition to this specification: None.
  • This work is being funded by: Google.

We'd prefer the TAG provide feedback as:

🐛 open issues in our GitHub repo for each point of feedback: https://github.com/w3c/csswg-drafts/issues with css-view-transitions-2 label.

@plinss plinss self-assigned this May 1, 2024
@plinss plinss added the Mode: breakout Work done during a time-limited breakout session label May 1, 2024
@torgo torgo added this to the 2024-05-06-week milestone May 5, 2024
@plinss plinss removed this from the 2024-05-13-week:b milestone May 27, 2024
@torgo torgo added this to the 2024-06-17-week:a milestone Jun 16, 2024
@torgo torgo added the Progress: propose closing we think it should be closed but are waiting on some feedback or consensus label Jun 17, 2024
@plinss
Copy link
Member

plinss commented Aug 5, 2024

Thanks for bearing with us. After reviewing and discussing internally, we have one question which is: did you discuss the option of using selectors and if so could you document in the explainer the reasoning for not using that approach?

We see the extra layer of indirection as being useful if view transitions can be used with multiple arbitrary pages, but it's unclear if the transitions will be generic enough in general to be reused. If the transitions need to be tailored to the specific page content then an extra layer of indirection doesn't seem useful.

@LeaVerou
Copy link
Member

LeaVerou commented Oct 28, 2024

We looked at this again today in a breakout. While we recognize that the use case is prevalent, we still have serious concerns about the ergonomics and syntax of this solution.

We would prefer that a solution is designed that eliminates the indirection and repetition this forces authors into. For example, one potential solution could be having the UA scan for selector arguments to ::view-transition-group() and essentially generating these rules behind the scenes.

If an alternative design is not an option, we would strongly urge the proposers to consider framing this as a separate concept and not drawing links to classes (syntactic or conceptual), as we believe this will be confusing for authors.

We'll file an issue with the CSS WG to explore these points, and we expect further discussion to happen there.

@plinss plinss removed this from the 2024-10-28-week milestone Nov 4, 2024
@torgo torgo added this to the 2025-01-06-week milestone Jan 3, 2025
@plinss plinss removed this from the 2025-01-06-week milestone Jan 13, 2025
@torgo torgo added this to the 2025-01-20-week milestone Jan 19, 2025
@torgo torgo modified the milestones: 2025-01-27-week, 2025-02-03-week Feb 2, 2025
@xiaochengh xiaochengh assigned xiaochengh and unassigned LeaVerou Feb 4, 2025
@torgo torgo modified the milestones: 2025-02-03-week, 2025-02-10-week Feb 9, 2025
@torgo torgo unassigned plinss Feb 9, 2025
@jyasskin
Copy link
Contributor

We note that this feature has consensus from the relevant working groups, and we don't think the TAG has much more to add here. Thanks for bearing with us.

@jyasskin jyasskin added Progress: review complete Resolution: decline The TAG declines to review this work. We don't think our review would add much. We don't object. and removed Progress: propose closing we think it should be closed but are waiting on some feedback or consensus labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: Accessibility (pending) Focus: API design (pending) Mode: breakout Work done during a time-limited breakout session Progress: review complete Resolution: decline The TAG declines to review this work. We don't think our review would add much. We don't object. Topic: accessibility Topic: CSS Venue: CSS WG
Projects
None yet
Development

No branches or pull requests

10 participants