Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing any page on the frontend ends up in a 404 #33

Open
Eijebong opened this issue Nov 22, 2021 · 4 comments
Open

Refreshing any page on the frontend ends up in a 404 #33

Eijebong opened this issue Nov 22, 2021 · 4 comments

Comments

@Eijebong
Copy link

Steps to reproduce:

  • Go to the login page (tested with /dashboard too)
  • Press F5
@w4
Copy link
Owner

w4 commented Nov 22, 2021

Thanks for the report, I think this is related to the move to React Router v6. I'll try to reproduce and push up a fix today

@w4
Copy link
Owner

w4 commented Nov 22, 2021

Seems to be the other way round, I can reproduce this on v0.1.0 but not master. Can you confirm this is the case? If so, I'll release v0.1.1 today

@Eijebong
Copy link
Author

Oh, found why. I'm running this without docker because I'm testing and... SERVER_ERROR_PAGE_404=./index.html that's why

@w4
Copy link
Owner

w4 commented Nov 22, 2021

Ah, makes sense. Good to know there's (likely) not broken code released. Fwiw, during development I usually run the frontend using yarn start under chartered-frontend with the git and web configs:

chartered/chartered-git on  HEAD (a2337df) is 📦 v0.1.0 via 🦀 v1.56.1
❯ cat config.toml
bind_address = "127.0.0.1:2233"
database_uri = "sqlite://chartered.db"
web_base_uri = "http://localhost:8888/"

[committer]
name = "Chartered"
email = "noreply@chart.rs"
message = "Updated crates!"

and

chartered/chartered-web on  HEAD (a2337df) is 📦 v0.1.0 via 🦀 v1.56.1
❯ cat config.toml
bind_address = "127.0.0.1:8888"
database_uri = "sqlite://chartered.db"
encryption_key = "this is a cool encryption key123"
storage_uri = "file:///tmp"
frontend_base_uri = "http://localhost:1234/"

[auth.password]
enabled = true
❯ cargo run --bin chartered-web --features sqlite -- -c ./chartered-web/config.toml
❯ cargo run --bin chartered-git --features sqlite -- -c ./chartered-git/config.toml

That reminds me, I really need to make a development/non-Docker setup guide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants