Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default task limits should be based on memory and core count, not only core count #2617

Open
AaronFriel opened this issue Sep 17, 2024 · 1 comment
Labels
bug Something isn't working Stale

Comments

@AaronFriel
Copy link

AaronFriel commented Sep 17, 2024

Describe the bug

Wabbajack by default is using 112GiB of memory, or around 1.75GiB per logical CPU on this machine.

image

Additional Context

This computer has an AMD CPU with 64 logical cores. The default of using 64 tasks seems to result in fairly poor performance. Perhaps the default task limits should be determined by say, max(logical cores, gigabytes of RAM / 4)?

Wabbajack version is 3.7.2.1.

@tr4wzified tr4wzified added the bug Something isn't working label Sep 18, 2024
Copy link

Marked as stale due to no interactions in the last 90 days. If the issue still exists, please provide any possibly still needed information or excuse the devs for not getting around to addressing this issue yet. If this issue is still considered unsolved a dev will soon remove the stale tag from this issue.

@github-actions github-actions bot added the Stale label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants