Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accepted와 online input형식 #183

Open
eldpswp99 opened this issue Sep 23, 2020 · 3 comments
Open

accepted와 online input형식 #183

eldpswp99 opened this issue Sep 23, 2020 · 3 comments
Labels
backend HW2 question Further information is requested specification issues related with specification of assignments

Comments

@eldpswp99
Copy link
Member

eldpswp99 commented Sep 23, 2020 •
edited
Loading

accepted와 online input같은 경우
serializer가 boolean value checking하는 것을 그대로 사용해도 괜찮을까요?

online은 True 또는 False와 같은 대소문자 무관한 문자열이어야 하며

라고 언급되어 있는데, trUE, faLse와 같은 경우도 valid input으로 생각해야 되나요 아니면, serializer.BooleanField의 기본 세팅을 활용해도 괜찮을까요?

accepted같은 경우, request body에 전달되지 않는다면 validated_error를 주는게 아니라, 기본 false로 두고 user를 생성했는데, 이렇게 생각해도 괜찮을까요?
@eldpswp99 eldpswp99 changed the title accepted와 online input형식에 대해 질문드립니다. accepted와 online input형식 Sep 23, 2020
@cs71107
Copy link
Collaborator

cs71107 commented Sep 23, 2020

엇, 전 기본으로 True를 주고 작업했는데... 혹시 나중에 문제가 될까요...

@YeonghyeonKO
Copy link
Member

저는 BooleanField 사용했습니다!

@davin111
Copy link
Member

@eldpswp99 serializers.BooleanField가 TRUE_VALUES, FALSE_VALUES로 취급하는 것들 정도만 고려하시면 됩니다!

@davin111 davin111 added backend HW2 question Further information is requested specification issues related with specification of assignments labels Sep 23, 2020
@eldpswp99 eldpswp99 mentioned this issue Sep 30, 2020
Open
@davin111 davin111 mentioned this issue Oct 1, 2020
Merged
@eldpswp99 eldpswp99 mentioned this issue Oct 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend HW2 question Further information is requested specification issues related with specification of assignments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davin111 @YeonghyeonKO @eldpswp99 @cs71107