Translation errors can’t be fixed using Pontoon

[TheoChevalier]

STR:

• Send a translation using Pontoon with a translation error (e.g. going over the character limit)
• Send a shortened version of the translation using Pontoon

Current behavior:

The translation is updated, but the error remains, and the character count still reflects the old translation’s length. The translation won’t get published until a Wagtail admin manually edits then save the translation.

Expected:
The error disappears as soon as a valid translation comes from Pontoon and is immediately published

[kaedroho]

When translations are updated from a PO file, we're not clearing the "has_error" flag.

This code only sets it to false when it creates a new translation:

wagtail-localize/wagtail_localize/models.py

Line 1090 in 14d8b1a

'has_error': False,

The solution would be to check if created is False and update any fields that need to be changed