You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I have a few issues regarding the install script. I understand that this plugin is rather small and can't address complex and rare situations during its installations. But I'll list them anyway:
Why does it need sudo? It doesn't fail without it, and there shouldn't be a reason for it to - we're only copying files into a folder under ~/.local. If the user decides to use a different directory for plugins and root privileges are required for that, he will most likely know himself that he needs sudo
wakatime presence is detected by importing, but always used as subprocess. This also broke in my case, as I had WakaTime CLI installed with pipx – in an isolated environment, and only a special wakatime executable is placed in ~/.local/bin. However, it's not available for import, so the install script didn't detect it, and installed it again with pip, overwriting the executable.
The CLI should probably be updated at some point too,
Gedit version detection. Currently, there's hardcoded version 3. I found two places where I could get some versions – gi.__version__ gives me 3.36.0, gi._versions["Gedit"] gives 3.0. But my Gedit shows 3.36.2.
The text was updated successfully, but these errors were encountered:
Hello, I have a few issues regarding the install script. I understand that this plugin is rather small and can't address complex and rare situations during its installations. But I'll list them anyway:
Why does it need
sudo
? It doesn't fail without it, and there shouldn't be a reason for it to - we're only copying files into a folder under~/.local
. If the user decides to use a different directory for plugins and root privileges are required for that, he will most likely know himself that he needssudo
pip
, WakaTime CLI installationpip
shouldn't be used by importing. Replace withsubprocess
wakatime
presence is detected by importing, but always used assubprocess
. This also broke in my case, as I had WakaTime CLI installed withpipx
– in an isolated environment, and only a specialwakatime
executable is placed in~/.local/bin
. However, it's not available for import, so the install script didn't detect it, and installed it again withpip
, overwriting the executable.Gedit version detection. Currently, there's hardcoded version 3. I found two places where I could get some versions –
gi.__version__
gives me3.36.0
,gi._versions["Gedit"]
gives3.0
. But my Gedit shows3.36.2
.The text was updated successfully, but these errors were encountered: