Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for latest version on the main thread #115

Closed
rchl opened this issue Jun 23, 2022 · 2 comments
Closed

Checks for latest version on the main thread #115

rchl opened this issue Jun 23, 2022 · 2 comments

Comments

@rchl
Copy link

rchl commented Jun 23, 2022

This package makes a network request on the main thread:

headers, contents, code = request(GITHUB_RELEASES_STABLE_URL, last_modified=last_modified)

That means that if there are issues with the network connection on starting ST, this call will freeze ST for good amount of seconds.

This check should be done on a separate thread.

Potentially the isCliLatest check could also be done from a separate thread as it's doing file IO but I don't see this causing issue unless there is something wrong with the hard drive or something.

@alanhamlett
Copy link
Member

Fixed with c1f58fd and released in v11.0.7.

@rchl
Copy link
Author

rchl commented Jun 26, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants