Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: add tests #72

Closed
fryorcraken opened this issue Aug 26, 2022 · 2 comments
Closed

Examples: add tests #72

fryorcraken opened this issue Aug 26, 2022 · 2 comments
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@fryorcraken
Copy link
Collaborator

non-regression tests are needed to ensure that the show case, deployed on master branch updates, still works.

Also, remove WakuMock once the tests are in place.

@fryorcraken fryorcraken moved this to Todo in Waku Aug 26, 2022
@fryorcraken fryorcraken added this to Waku Aug 26, 2022
@fryorcraken fryorcraken added test Issue related to the test suite with no expected consequence to production code track:maintenance labels Aug 26, 2022
@fryorcraken fryorcraken changed the title [web-chat] Add tests Examples: add tests Feb 14, 2023
@fryorcraken
Copy link
Collaborator Author

fryorcraken commented Feb 14, 2023

Adding remove some agility to examples. As when a hacker play with them they may need to update/remove the tests.

Could do very basic tests:

  • check components are rendered/usable
  • Check no errors in logs

Best to ship first with the new react components.
Code readability is most important.

In terms of testing usefulness for examples. Hopefully, any functional issue with Waku would be detected in the js-waku test suite.
What could happen is the fact that the example does not use a Waku API correctly or hit a corner case which would lead to an error so the detection of error in logs would be a great start/low hanging fruit.

@fryorcraken fryorcraken moved this from Todo to Icebox in Waku Feb 14, 2023
@weboko
Copy link
Contributor

weboko commented Oct 27, 2023

In waku-org/js-waku#1542 this was partially addressed.
Other things will be completed in waku-org/js-waku#1597

I think at this point this issue can be closed.

@fryorcraken re-open if disagree

@weboko weboko closed this as completed Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue related to the test suite with no expected consequence to production code
Projects
Archived in project
Development

No branches or pull requests

2 participants