Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peer management with shard as a dimension #679

Closed
chair28980 opened this issue Aug 24, 2023 · 1 comment
Closed

feat: Peer management with shard as a dimension #679

chair28980 opened this issue Aug 24, 2023 · 1 comment
Assignees
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@chair28980
Copy link
Contributor

chair28980 commented Aug 24, 2023

If we assume that peer discovery takes care of filtering peers by shard, these peers must now be managed in a way that makes sense in a dynamic auto-sharded environment. Some requirements/ideas:

  • peer manager must preferably try to keep at least a target n peers for each subscribed shard (note that dynamically subscribing/unsubscribing from shards could complicate this)
  • peer manager must attempt to maintain a healthy relay connectivity for each subscribed shard
  • a mechanism to perform ad-hoc discovery (or another solution) to cater for when a node subscribes to a shard for which there are no tracked peers

Priority: Critical for launch

@chaitanyaprem
Copy link
Collaborator

Closing this issue as first two items have already been addressed via #727. It applies for both static and autosharding.
The 3rd item, i.e ad-hoc discovery is being tracked via #680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Archived in project
Development

No branches or pull requests

2 participants