Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Filter API to provide sharding specific ContentFilter options #756

Closed
3 tasks
chaitanyaprem opened this issue Sep 20, 2023 · 1 comment
Closed
3 tasks

Comments

@chaitanyaprem
Copy link
Collaborator

Background

Provide an option for users to specify or choose the type of ContentFilter they want to use as per the type of relay-sharding required by the application (Named, Static or Auto sharding)

Details

Improve the devEx by providing option for users to specify which type of ContentFilter they want to use.
Users can specify AutoShardingContentFilter (which only accepts contentTopics) or NamedStaticShardingContentFilter(which accepts both pubSubtopic and a list of contentTopics). This would prevent misuse of API and running into issues.

Refer discussion here

Acceptance criteria

All following API's should be modified to accept new shard specific contentFilters

  • Go API
  • mobile API
  • c-bindings
@chaitanyaprem chaitanyaprem self-assigned this Sep 20, 2023
@chaitanyaprem chaitanyaprem moved this to To Do in Waku Sep 20, 2023
@chair28980 chair28980 moved this from To Do to Priority in Waku Oct 31, 2023
@chair28980 chair28980 moved this from Priority to Icebox in Waku Nov 7, 2023
@chaitanyaprem chaitanyaprem removed their assignment Dec 26, 2023
@chaitanyaprem
Copy link
Collaborator Author

Descoping from go-waku

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant