Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Maintain non full-mesh peerings for each topic/shard #781

Closed
chaitanyaprem opened this issue Sep 27, 2023 · 1 comment
Closed

feat: Maintain non full-mesh peerings for each topic/shard #781

chaitanyaprem opened this issue Sep 27, 2023 · 1 comment

Comments

@chaitanyaprem
Copy link
Collaborator

Problem

With #727 , peer-manager ensure min of D peers are maintained.
But, in order for gossipSub to be efficient, metadata only peers are also to be maintained.
This doesn't impact any performance with current approach but in long run may have an impact on serviceNode and relay nodes.

But, this information of whether a peer is fullMesh or metadata only is not available at Waku-layer and hence would require changes to go-libp2p-pubsub to expose this info so that peerManager can take decisions accordingly.

Suggested solution

To be analyzed if there are any alternatives.

Acceptance criteria

Verify that both fullMesh and metadata only peer connections are maintained for all subscribed shards or pubSubTopics.

@fryorcraken fryorcraken added this to Waku Sep 27, 2023
@chaitanyaprem chaitanyaprem moved this to Icebox in Waku Nov 24, 2023
@chaitanyaprem
Copy link
Collaborator Author

Closing the issue as it is descoped for go-waku.

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant