Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p bug: invalid p2p address returned in call to listenAddresses() when intializing libp2p host with localhost #802

Closed
chaitanyaprem opened this issue Oct 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@chaitanyaprem
Copy link
Collaborator

Describe the bug
In peermanager test code, when extracting multiaddresses for host created using localhost address go-libp2p's call to fetch listen addresses via h.Network().ListenAddresses() seems to be returning an empty p2p-circuit address which has lead to write conditional code.

Refer #787 (comment)

Expected behavior
Call to fetch network listen addresses should return only valid addresses.

@richard-ramos
Copy link
Member

Closing as discussed on 02/13 go-waku PM call. This issue is already handled in the code.

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants