Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js-rln keystore is not compatible with nwaku #80

Closed
alrevuelta opened this issue Nov 7, 2023 · 2 comments · Fixed by waku-org/nwaku#2200
Closed

js-rln keystore is not compatible with nwaku #80

alrevuelta opened this issue Nov 7, 2023 · 2 comments · Fixed by waku-org/nwaku#2200
Assignees
@weboko
Labels
bug Something isn't working

Comments

@alrevuelta
Copy link

When generating a keystore with js-rln (using the frontend repo) and then importing it into nwaku it fails to load.

The error that nwaku raises:

Error: unhandled exception: Trying to access value with err Result: keystore error: OS specific error: Incorrect JSON kind. Wanted '{JNull, JString}' in '.membershipContract.chainId' but got 'JInt'. [ResultDefect]

Any idea?
@fryorcraken fryorcraken added this to Waku Nov 7, 2023
@chair28980 chair28980 moved this to Priority in Waku Nov 7, 2023
@weboko weboko added the bug Something isn't working label Nov 7, 2023
@weboko
Copy link
Contributor

weboko commented Nov 8, 2023

Ok, turns out Keystore generated by nwaku is not a valid JSON.
Specifically - nwaku adds trailing commas that are allowed in JSON files.

js-rln.json
nwaku.json

Refs: MDN, the spec

@weboko weboko moved this from Priority to Code Review / QA in Waku Nov 8, 2023
@weboko weboko self-assigned this Nov 8, 2023
@weboko weboko moved this from Code Review / QA to Done in Waku Nov 8, 2023
@weboko weboko mentioned this issue Nov 8, 2023
Merged
@weboko
Copy link
Contributor

weboko commented Nov 8, 2023

Should be resolved by waku-org/nwaku#2200

@weboko weboko moved this from Done to Code Review / QA in Waku Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
bug Something isn't working
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove trailing commas from keystore json waku-org/nwaku
2 participants
@alrevuelta @weboko